On 07.11.19 15:21, Tomas Hozza wrote: > Hi. > > In RHEL-8, we ship a wget version that suffers from bug fixed by [1]. The fix > resolved issue with matching subdomains when no_proxy domain definition was > prefixed with dot, e.q. "no_prefix=.mit.edu". As part of backporting the fix > to RHEL, I wanted to create an upstream test for no_prefix functionality. > However I found that there is still one corner case, which is not handled by > the current upstream code and honestly I'm not sure what is the intended > domain matching behavior in that case. Man page is also not very specific in > this regard. > > The corner case is as follows: > - no_proxy=.mit.edu > - download URL is e.g. "http://mit.edu/file1"; > > In this case the proxy settings are used, because domains don't match due to > the leftmost dot in no_proxy domain definition. This is either intended or > corner case that was not considered. One could argue, that if the no_proxy is > set to ".mit.edu", then leftmost dot means that the proxy settings should not > apply only to subdomains of "mit.edu", but proxy settings should still apply > to "mit.edu" domain itself. From my point of view, after reading wget man > page, I don't think that the leftmost dost in no_proxy definition has any > special meaning.
Hello Tomas, hard to decide how to handle this. I personally would like to see a match with curl's behavior (see https://github.com/curl/curl/issues/1208). Given the docs from GNU emacs, you are right. "no_proxy=.mit.edu" means "mit.edu and subdomains" are excluded from proxy settings. (see https://www.gnu.org/software/emacs/manual/html_node/url/Proxies.html) The caveat with emacs' behavior is that you cannot exclude just all subdomains of mit.edu without mit.edu itself. Effectively, that creates a corner case that can't be handled at all. (but if curl also does it that way, let's go for it). Maybe you can find out about the current no_proxy behavior of typical and wide-spread tools (regarding leftmost dot) !? Once we have that information, we can make a confident decision. Regards, Tim > I think that this corner case should be either fixed, or alternatively wget > manpage should be made more specific about the intended behavior. > > Anyway, I'm attaching patches fixing the corner case and adding test case for > no_proxy behavior. And one small fix for the test framework - HttpTest > begin() function was not returning a result value, but always None. > > Please let me know if the corner case is really an intended behavior and I'll > change the test case and can fix the man page instead of the code. > > [1] > http://git.savannah.gnu.org/cgit/wget.git/commit/?id=fd85ac9cc623847e9d94d9f9241ab34e2c146cbf > > Thank you. > > Regards, > Tomas >
signature.asc
Description: OpenPGP digital signature
