DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=39380>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39380 ------- Additional Comments From [EMAIL PROTECTED] 2006-04-22 15:13 ------- (In reply to comment #3) > OK. I'll start with two patches that are small and separated. > > How do you propose to handle the rest? The problem is that since almost all > changes affect store_body() the only way for all of them to apply cleanly is > to make them depend on eachother. Is this OK? Yes, this is ok. Sorry that I have not been more precise on this subject. I would like to see the low hanging fruits first, so that we get in the easiest things first. By easy I also mean with possible least discussion on the mailing list. So I would propose the following order for the patches: * Consequently use disk_cache: in error log strings. (Yes, I am serious. I like to see this as a separate patch that goes in first, as it actually does not really touch code.) * Try to check if allowed to cache the file before caching it too, first caching bits of a huge file and then toss it makes little sense. * Implement Large File Support (LFS) in mod_disk_cache. * When caching a file, copy it using the file descriptor in the brigade instead of using apr_bucket_read which forces the file into memory. This produced a segfault if trying to cache a file larger than the available amount of memory. * When having cached a file, replace the brigade referring to the source file with our cached copy. This makes a huge difference when the file is larger than your memory and thus not in cache, given that your cache filesystem is faster than your backend (a natural assumption, why cache otherwise?). * In mod_cache, restore r->filename so %f in LogFormat strings work. This really should be solved by saving r->filename with the headers and restore it in mod_disk_cache et al, but this at least provides something. * When caching a file, keep the cache file even if the connection was aborted. There is no reason to toss it, and the penalty for doing so when caching DVD images is really huge. * When multiple downloads of an uncached file is initiated, only allow one of them to cache the file and let the others wait for the result. It's not a theoretically perfect solution, but in practice it seems to work well. Don't feel discouraged if answers to single patches take longer. This is no lack of interest, but in most cases lack of time or the need for a discussion on the developer list. Feel free to give a ping here if you think that things stalled completely. Thanks for your understanding and patience. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
