https://bz.apache.org/bugzilla/show_bug.cgi?id=61222
--- Comment #20 from Ruediger Pluem <[email protected]> --- (In reply to Joe Orton from comment #19) > I think the patch which removed 40 lines of code was cooler :( > > The brigade cleanup is done for r->pool anyway, I dislike adding explicit > cleanups when we can let the pools do their job! Fair enough. > > I committed this in r1808230. > > There are definitely cases we could further optimise here. e.g. where the > entire brigade length is determinable, we could find C-L without an > intermediate ap_pass_brigade. [HEAP FLUSH HEAP EOS] is an example where > we'll now chunk when we could determine C-L. > > I don't know if it's worth the effort to optimise that; arguably content > generators which produce excessive FLUSH buckets should be treated as > streamy producers. I don't think that it is worth the effort. These generators should be considered streamy producers as you say. I also doubt that we see [HEAP FLUSH HEAP EOS] in practice. More likely we see [HEAP FLUSH] which resulted in chunked encoding so far as well. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
