https://bz.apache.org/bugzilla/show_bug.cgi?id=57337

--- Comment #3 from Alex Smith <[email protected]> ---
Created attachment 36019
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36019&action=edit
Suggested improvement for reporting of `redirect of negotiation variant'
configuration errors

Additional patch with a tangential improvement for consideration, in case it is
useful.

As mentioned in the analysis in #2, when mod_negotiation is performing
sub-requests for the possible variants it assumes anything other than a
`success' return indicates an error and bails with a 404 Not Found response. If
such a sub-request actually fails then that failure will likely be logged as
well and it will be clear what the issue is. However the case that a
sub-request gives a redirection response is arguably a configuration error that
needs to be logged as such. Currently in this case there is little indication
of the cause of the negotiation failure, since both the negotiation and
redirection configurations are likely valid on their own and hence no other
errors or warnings are logged; it is only their combination that is in error.

This patch simply puts in handling for this special case of negotiation
failure, logging a more helpful error and returning 500 Internal Server Error.

Apply with `patch -p1' in the root directory. Taken against 2.4.33 but applies
cleanly to current trunk. Only tested against 2.4.33 though. Would need a
proper error number assigning before inclusion.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to