https://bz.apache.org/bugzilla/show_bug.cgi?id=61355
--- Comment #12 from Eric Covener <cove...@gmail.com> --- (In reply to Cyril B. from comment #11) > I've used the patch in production on 2.4.43 and had random Segmentation > faults. Fixed by replacing: > > + r->server->server_scheme = scheme; > > with: > > + r->server->server_scheme = "https"; This is a good catch, but I think both approaches are incorrect. It is not valid for a per-request header to change the state of anything like r->-server->* . In your case it will probably not lead to incorrect results since it does not actually vary per-request, but then you should also just use a scheme in the ServerName directive if it does not vary. I think the approach that fits w/ the Apache API is for something like mod_remoteip to implement the http_scheme callback to override the server scheme. Or, mod_dir should stop calling ap_construct_url and just return non fully qualified URL's and let the browser sort it out. This was not spec in the original HTTP/1.1 RFC but was in use forever and is valid now. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
