https://bz.apache.org/bugzilla/show_bug.cgi?id=65155
--- Comment #2 from Andrei <[email protected]> --- I've just tried now to create a PR ( https://github.com/apache/httpd/pull/173 ) but the change fails because C89/C90 style is (still) being used (e.g. https://travis-ci.com/github/apache/httpd/jobs/486139913 ) ab.c:1874:5: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement] const char *const http_version = http_spec == HTTP_1_1 ? "HTTP/1.1" : "HTTP/1.0"; ^~~~~ I would have preferred to use a const pointer, but that would mean to move all three initializations to the top of the function. Which solution is preferred? * move definitions and initialization at the top of the file * define at top, initialize just before apr_snprintf * inline again the initialization as arguments to the apr_snprintf function (I don't find this easily readable) -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
