https://bz.apache.org/bugzilla/show_bug.cgi?id=70028

--- Comment #2 from abernal <[email protected]> ---
This is fixed in trunk by r1939267 (commit 6f0c237673, "mod_cache: Parse comma
separated Cache-Control directives again"). cache_strqtok() did not end a token
at a comma or whitespace unless an argument followed, so "private, no-store"
was read as one token and the response was stored. The fix stops the token at
any non-token character, and it adds
test/modules/proxy/test_07_cache_control.py.

I ran that test on a trunk build with the fix, and again after removing the
three lines of the fix from cache_util.c: with the fix 25 tests pass, without
it 10 of the 25 fail, which includes the cases for "private, no-store". With
the fix put back, all 25 pass again.

I did not check it with other backends than the one of the test. 2.4.x does not
have the state machine that the fix changes (no IN_BETWEEN in its
cache_util.c), which matches the statement in the commit message that this is a
regression of trunk only, so I do not see a backport to 2.4.x. This bug can be
resolved as fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to