On 19/01/15(Mon) 07:40, Theo Buehler wrote: > > The report_id variable doesn't do anything anymore, so one might as > well eliminate it entirely, no?
I didn't delete it because I'd like to use it and I don't see the point into diverging more from FreeBSD. If you're interested into this kind of stuff, I'd prefer to see diffs to make the kernel aware of the reportID so that devices handling multiple reportIDs like upd(4) can be queried from userland. > Index: lib/libusbhid/parse.c > =================================================================== > RCS file: /cvs/src/lib/libusbhid/parse.c,v > retrieving revision 1.10 > diff -u -p -r1.10 parse.c > --- parse.c 18 Jan 2015 17:16:06 -0000 1.10 > +++ parse.c 19 Jan 2015 06:32:45 -0000 > @@ -513,7 +513,6 @@ hid_report_size(report_desc_t r, enum hi > uint32_t temp; > uint32_t hpos; > uint32_t lpos; > - int report_id = 0; > > hpos = 0; > lpos = 0xFFFFFFFF; > @@ -529,8 +528,6 @@ hid_report_size(report_desc_t r, enum hi > /* compute maximum */ > if (hpos < temp) > hpos = temp; > - if (h.report_ID != 0) > - report_id = 1; > } > } > hid_end_parse(d); >
