On 02/02/16(Tue) 09:14, Stefan Sperling wrote:
> On Sat, Jan 30, 2016 at 10:49:38PM +1300, Richard Procter wrote:
> > -           ring->queued--;
> > +           atomic_dec_int(&ring->queued);
> 
> > -   ring->queued += ntxds;
> > +   atomic_add_int(&ring->queued, ntxds);
> 
> I don't think these make a difference in the current way of things.

It does not, the wireless stack needs some love before wifi drivers can
have their interrupt handlers marked as mp-safe.

> Wireless drivers run interrupts under the kernel big lock, interrupts
> aren't preemptible, and AFAIK (most?) 32bit integer operations are atomic.

Adding/decrementing are not because you need to reading the existing
value then write the modified one :)

Reply via email to