On Wed, May 18, 2016 at 02:30:11AM -0400, James Hastings wrote:
> >Synopsis: acpitz0: _AL0[0] _PR0 failed
> >Category: system
> >Environment:
> System : OpenBSD 6.0
> Details : OpenBSD 6.0-beta (GENERIC) #1925: Tue May 17 09:37:26 MDT
> 2016
>
> dera...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC
>
> Architecture: OpenBSD.amd64
> Machine : amd64
>
> >Description:
> every 10 seconds console message: acpitz0: _AL0[0] _PR0 failed
> occurs in -current
> does not occur in 5.9
> >How-To-Repeat:
> clean install -current
> >Fix:
> unsure
I think it is related to last diff commited:
----------------------------
revision 1.50
date: 2016/04/26 09:42:57; author: semarie; state: Exp; lines: +6 -3;
commitid: ZEmGqTk6vXPvhhU5;
corrects acpitz problem with active cooling and hysterisis
"if the temperature is below the active cooling level for a tz, turn the fan off
regardless of what state it is currently in"
ok mlarkin@
----------------------------
the error message should coming from acpitz_setfan() function.
I will try to understand elements.
Could you try the following diff (reverting previous commit) in order to
be sure ?
Do you see any acpitz0 message again (perhaps just one) ?
Thanks.
--
Sebastien Marie
Index: acpitz.c
===================================================================
RCS file: /cvs/src/sys/dev/acpi/acpitz.c,v
retrieving revision 1.50
retrieving revision 1.49
diff -u -p -r1.50 -r1.49
--- acpitz.c 26 Apr 2016 09:42:57 -0000 1.50
+++ acpitz.c 6 May 2015 01:41:55 -0000 1.49
@@ -37,7 +37,6 @@
#define KTOC(k) ((k - 2732) / 10)
#define ACPITZ_MAX_AC (10)
#define ACPITZ_TMP_RETRY (3)
-#define ACPITZ_UNKNOWN (-1)
struct acpitz_softc {
struct device sc_dev;
@@ -140,6 +139,7 @@ acpitz_init(struct acpitz_softc *sc, int
for (i = 0; i < ACPITZ_MAX_AC; i++) {
snprintf(name, sizeof(name), "_AC%d", i);
sc->sc_ac[i] = acpitz_getreading(sc, name);
+ sc->sc_ac_stat[i] = -1;
}
}
@@ -160,8 +160,6 @@ acpitz_init(struct acpitz_softc *sc, int
sc->sc_devnode, &res, 0);
aml_freevalue(&res);
}
- /* initialize current state to unknown */
- sc->sc_ac_stat[i] = ACPITZ_UNKNOWN;
}
}
}
@@ -425,8 +423,7 @@ acpitz_refresh(void *arg)
acpitz_setfan(sc, i, "_ON_");
} else if (sc->sc_ac[i] != -1) {
/* turn off fan i */
- if ((sc->sc_ac_stat[i] == ACPITZ_UNKNOWN) ||
- (sc->sc_ac_stat[i] > 0))
+ if (sc->sc_ac_stat[i] > 0)
acpitz_setfan(sc, i, "_OFF");
}
}
