On 30.4.2019. 23:40, Martin Pieuchot wrote:
> On 30/04/19(Tue) 14:45, Hrvoje Popovski wrote:
>> Hi all,
>>
>> if i have bridge with rstp on interfaces and rstp on switch and i want
>> to disable rstp on openbsd interfaces i'm getting fault trap. I can
>> reproduce it on 6.4 and on -current.
>> i can't reproduce it if i don't have rstp on switch.
> 
> Seems that `bs_root_port' isn't reset.  Does the diff below help?
> 

Hi,

yes, it helps. i can't reproduce trap with ifconfig bridge0 after
removing stp from interfaces in bridge. But now if i destroy bridge0
after removing stp from interfaces box freeze and if in second terminal
i execute reboot i'm getting same or similar trap. i didn't try ifconfig
bridge0 destroy without this diff ..



bridge0: flags=41<UP,RUNNING>
        index 18 llprio 3
        groups: bridge
        priority 32768 hellotime 2 fwddelay 15 maxage 20 holdcnt 6 proto
rstp
        ix1 flags=eb<LEARNING,DISCOVER,STP,AUTOEDGE,PTP,AUTOPTP>
                port 6 ifpriority 128 ifcost 2000 learning role root
        ix0 flags=eb<LEARNING,DISCOVER,STP,AUTOEDGE,PTP,AUTOPTP>
                port 5 ifpriority 128 ifcost 2000 discarding role alternate
x3550m4# ifconfig bridge0 -stp ix0
x3550m4# ifconfig bridge0 -stp ix1
x3550m4# ifconfig bridge0
bridge0: flags=41<UP,RUNNING>
        index 18 llprio 3
        groups: bridge
        priority 32768 hellotime 2 fwddelay 15 maxage 20 holdcnt 6 proto
rstp
        designated: id a0:36:9f:2e:96:a1 priority 32768
        ix1 flags=e3<LEARNING,DISCOVER,AUTOEDGE,PTP,AUTOPTP>
                port 6 ifpriority 0 ifcost 0
        ix0 flags=e3<LEARNING,DISCOVER,AUTOEDGE,PTP,AUTOPTP>
                port 5 ifpriority 0 ifcost 0
        Addresses (max cache: 100, timeout: 240):
                00:01:e8:8a:ea:53 ix1 1 flags=0<>
x3550m4# ifconfig bridge0 destroy

after this box freeze and when trying to reboot in other terminal i'm
getting this:

uvm_fault(0xfffffd87845eae78, 0x50, 0, 1) -> e
kernel: page fault trap, code=0
Stopped at      bridge_ioctl+0x25d:     movq    0x10(%rax),%rax

ddb{5}> trace
bridge_ioctl(ffff800000aa1000,c0406958,ffff800025c803c0) at
bridge_ioctl+0x25d
ifioctl(fffffd8784f154a8,c0406958,ffff800025c803c0,ffff8000fffef790) at
ifioctl+0x2e1
sys_ioctl(ffff8000fffef790,ffff800025c804e0,ffff800025c80550) at
sys_ioctl+0x3c4
syscall(ffff800025c805c0) at syscall+0x2d5
Xsyscall(6,36,7f7ffffbdd60,36,7f7ffffbd7e0,1120dda0c53f) at Xsyscall+0x128
end of kernel
end trace frame: 0x7f7ffffbd840, count: -5
ddb{5}>

ddb{5}> ps
   PID     TID   PPID    UID  S       FLAGS  WAIT          COMMAND
  8881  355476  58607      0  3    0x100080  piperd        sh
*61948  478931  58607      0  7         0x2                ifconfig
 58607  500143  60114      0  3    0x10008a  pause         sh
 60114  118807   9999      0  3        0x83  wait          reboot
  9999  475759  36533      0  3    0x10008b  pause         ksh
 36533  245986  54582   1000  3    0x10008b  pause         ksh
 54582   88066  51228   1000  3        0x90  select        sshd
 51228  249575  10714      0  3        0x82  poll          sshd
 89349   12679  78679      0  3         0x3  ifidxrm       ifconfig
 78679  494362      1      0  3    0x10008b  pause         ksh
 23063  361819      1      0  3    0x100083  ttyin         getty
  5688  521523      1      0  3    0x100083  ttyin         getty
 10811  485927      1      0  3    0x100083  ttyin         getty
 53603  187259      1      0  3    0x100083  ttyin         getty
 76136  329246      1      0  3    0x100083  ttyin         getty
 37428   18304      1      0  3    0x100098  poll          cron
 35480   87192  93615     95  3    0x100092  kqread        smtpd
 36138    5975  93615    103  3    0x100092  kqread        smtpd
 30067   12755  93615     95  3    0x100092  kqread        smtpd
 93539  274871  93615     95  3    0x100092  kqread        smtpd
 22439  508287  93615     95  3    0x100092  kqread        smtpd
 72080  200916  93615     95  3    0x100092  kqread        smtpd
 93615  356738      1      0  3    0x100080  kqread        smtpd
 10714  370355      1      0  3        0x80  select        sshd
 28735  407225  44481     83  3    0x100092  poll          ntpd
 44481  159120  76739     83  3    0x100092  poll          ntpd
 76739  329789      1      0  3    0x100080  poll          ntpd
 65485  248241  32912     73  7    0x100090                syslogd
 32912  421250      1      0  3    0x100082  netio         syslogd
 96126  242404      0      0  3     0x14200  pgzero        zerothread
 73505  492214      0      0  3     0x14200  aiodoned      aiodoned
 89628  391838      0      0  3     0x14200  syncer        update
 33653  327764      0      0  3     0x14200  cleaner       cleaner
  7953  391928      0      0  3     0x14200  reaper        reaper
 16628    5698      0      0  3     0x14200  pgdaemon      pagedaemon
 29741  351482      0      0  3     0x14200  bored         crynlk
 44734  415647      0      0  3     0x14200  bored         crypto
 36512  227354      0      0  3     0x14200  usbtsk        usbtask
 38180   58616      0      0  3     0x14200  usbatsk       usbatsk
 68175  261381      0      0  3  0x40014200  acpi0         acpi0
 86409  319099      0      0  7  0x40014200                idle7
 72915  237117      0      0  7  0x40014200                idle6
 44894  189254      0      0  3  0x40014200                idle5
 85283  213897      0      0  7  0x40014200                idle4
 82517  192655      0      0  7  0x40014200                idle3
 74089  489161      0      0  7  0x40014200                idle2
 77693  293039      0      0  3  0x40014200                idle1
 36269   92829      0      0  3     0x14200  bored         sensors
 88608  353656      0      0  3     0x14200  bored         softnet
 47764  444115      0      0  3     0x14200  bored         systqmp
 43276  167504      0      0  3     0x14200  bored         systq
 21301  325307      0      0  3  0x40014200  bored         softclock
 42291  286967      0      0  7  0x40014200                idle0
 20269  193379      0      0  3     0x14200  bored         smr
     1   56210      0      0  3        0x82  wait          init
     0       0     -1      0  3     0x10200  scheduler     swapper

ddb{5}> tr /t 0x478931
uvm_fault(0xfffffd87845eae78, 0x478939, 0, 1) -> e
kernel: page fault trap, code=0
Faulted in DDB; continuing...
ddb{5}>

Reply via email to