On 2021/03/13 16:38, [email protected] wrote:
> >Synopsis:    Undocumented change of struct usb_device_info
> >Category:    documentation kernel
> >Environment:
>       System      : OpenBSD 6.8
>       Details     : OpenBSD 6.8 (GENERIC.MP) #98: Sun Oct  4 18:13:26 MDT 2020
>                        
> [email protected]:/usr/src/sys/arch/amd64/compile/GENERIC.MP
> 
>       Architecture: OpenBSD.amd64
>       Machine     : amd64
> >Description:
>       struct usb_device_info has been changed in sys/dev/usb/usb.h from 
> version
>       1.59 to 1.60 on 2018-07-10 most probably resizing it and relocating its
>       last member udi_serial in memory.

That is not unusual, OpenBSD doesn't have particularly stable ABIs.

>     This change is not documented in usb(4).

That needs fixing.

Index: usb.4
===================================================================
RCS file: /cvs/src/share/man/man4/usb.4,v
retrieving revision 1.205
diff -u -p -r1.205 usb.4
--- usb.4       4 Feb 2021 16:25:38 -0000       1.205
+++ usb.4       13 Mar 2021 16:19:14 -0000
@@ -431,9 +431,11 @@ struct usb_device_info {
        u_int8_t        udi_protocol;
        u_int8_t        udi_config;
        u_int8_t        udi_speed;
-#define USB_SPEED_LOW  1
-#define USB_SPEED_FULL 2
-#define USB_SPEED_HIGH 3
+#define USB_SPEED_LOW  1
+#define USB_SPEED_FULL 2
+#define USB_SPEED_HIGH 3
+#define USB_SPEED_SUPER        4
+       u_int8_t        udi_port;
        int             udi_power;      /* power consumption */
        int             udi_nports;
        char            udi_devnames[USB_MAX_DEVNAMES]

Reply via email to