On Sun, Oct 24, 2021 at 08:04:26AM -0600, Theo de Raadt wrote: > Theo Buehler <t...@theobuehler.org> wrote: > > > On Sun, Oct 24, 2021 at 12:37:47PM +0000, Klemens Nanni wrote: > > > On Thu, Oct 21, 2021 at 10:29:02AM +0000, Klemens Nanni wrote: > > > > On Thu, Oct 21, 2021 at 04:06:53AM -0600, Theo de Raadt wrote: > > > > > Can people handle typing these passwords blindly? I suspect yes. > > > > > > > > > > Then this seems like a reasonable solution. > > > > > > > > Other systems do the redacted typing thing, so you see **** instead of > > > > what you actually typed; I think we're used to that and blindly typing > > > > is not much different... prompts like doas(1) do it as well. > > > > > > > > I didn't test autoinstall(8) and thought that was a problem since this > > > > diff changes the WEP/WPA passphrase questions from one to two answers if > > > > you will, but now I remembered that this obviously isn't a problem for > > > > the user password question either. > > > > > > > > Anyone willing to test this for me or even OK it? > > > > I can't do wifi installations here/now but am pretty confident that this > > > > does the right thing. > > > > > > New diff against -CURRENT. > > > > > > I'll commit this diff once I get positive feedback/an OK or tested it > > > myself. > > > > I'm not a fan. WiFi passwords tend to be on the longer side and > > nontrivial to type (they're also not things you tend to know by heart). > > I would not expect to be able to type my WiFi password blindly. > > So then we need a non-! parsing function, which doesn't disable echo.
I guess so. Not a big deal, I just tried the simple way and not write any new install.sub code. Will post a diff later.
