On Tue, Aug 02, 2022 at 10:44:00AM +0100, Laurence Tratt wrote: > I'm also starting to understand a bit more about some of the random panics: > they seem to happen very soon after X starts. Sometimes the mouse appears as > a two inch square of weird colours (!) -- things only last for a few seconds > after that. Only once have I got a visible panic out of this which said > solely: > > uvm_fault(0xffffffff822f0400, 0xfff80001660014, 0, 1) -> e > drm: Global state not read locked > drm: Global state not read locked > > That particular panic was on my custom compiled kernel, not the most recent > snapshot.
I don't see panics on a thinkpad with the same i7-1260P cpu Does this change help? drm/i915/adlp: Fix register corruption after DDI clock enabling >From Imre Deak 59207e63801fbcd39ca68df6e2ba5ae90f76c0c3 in mainline linux https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=59207e63801fbcd39ca68df6e2ba5ae90f76c0c3 I also wonder if it is somehow possible the "XXX on T14 Gen 3 resume" in sys/dev/pci/drm/i915/display/intel_bios.c intel_bios_is_port_edp() may be involved, but that is a stretch. Index: sys/dev/pci/drm/i915/i915_reg.h =================================================================== RCS file: /cvs/src/sys/dev/pci/drm/i915/i915_reg.h,v retrieving revision 1.29 diff -u -p -r1.29 i915_reg.h --- sys/dev/pci/drm/i915/i915_reg.h 21 Jun 2022 09:46:33 -0000 1.29 +++ sys/dev/pci/drm/i915/i915_reg.h 2 Aug 2022 10:16:01 -0000 @@ -8308,6 +8308,7 @@ enum { #define ICL_DELAY_PMRSP REG_BIT(22) #define DISABLE_FLR_SRC REG_BIT(15) #define MASK_WAKEMEM REG_BIT(13) +#define DDI_CLOCK_REG_ACCESS REG_BIT(7) #define GEN11_CHICKEN_DCPR_2 _MMIO(0x46434) #define DCPR_MASK_MAXLATENCY_MEMUP_CLR REG_BIT(27) Index: sys/dev/pci/drm/i915/intel_pm.c =================================================================== RCS file: /cvs/src/sys/dev/pci/drm/i915/intel_pm.c,v retrieving revision 1.63 diff -u -p -r1.63 intel_pm.c --- sys/dev/pci/drm/i915/intel_pm.c 6 Jun 2022 07:10:15 -0000 1.63 +++ sys/dev/pci/drm/i915/intel_pm.c 2 Aug 2022 10:15:13 -0000 @@ -7606,6 +7606,9 @@ static void adlp_init_clock_gating(struc /* Wa_22011091694:adlp */ intel_de_rmw(dev_priv, GEN9_CLKGATE_DIS_5, 0, DPCE_GATING_DIS); + + /* Bspec/49189 Initialize Sequence */ + intel_de_rmw(dev_priv, GEN8_CHICKEN_DCPR_1, DDI_CLOCK_REG_ACCESS, 0); } static void dg1_init_clock_gating(struct drm_i915_private *dev_priv)
