On 29/06/23(Thu) 11:17, Stefan Sperling wrote: > On Thu, Jun 29, 2023 at 10:59:32AM +0200, Martin Pieuchot wrote: > > On 28/06/23(Wed) 15:47, Moritz Buhl wrote: > > > Dear bugs@, > > > > > > with the following snapshot I had two panics on my x270 recently. > > > > This is a bug in iwm(4) suggesting a missing SPL protection. > > > > > sysctl kern.version > > > kern.version=OpenBSD 7.3-current (GENERIC.MP) #1256: Thu Jun 22 10:53:02 > > > MDT 2023 > > > dera...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP > > > > > > Below are transcribed pictures of my laptop screen. > > > > > > panic: rw_enter: vmmaplk locking against myself > > > Stopped at db_enter+0x14: popq %rbp > > > TID PID UID PRFLAGS PFLAGS CPU COMMAND > > > *258766 67401 1000 0x2100002 0x4000000 0K firefox > > > 465097 28019 0 0x14000 0x200 1 drmwq > > > db_enter () at db_enter+0x14 > > > panic(ffffffff820e78b0) at panic+0xc3 > > > rw_enter(fffffd87449a0f60,2) at rw_enter+0x26f > > > uvmfault_lookup(ffff800044cc3a30,0) at uvmfault_lookup+0x8a > > > uvm_fault_check(ffff800044cc3a30, ffff800044cc3a68,ffff800044cc3a90) at > > > uvm_fault_check+0x36 > > > uvm_fault(fffffd87449a0e78,ab6ed8ea000,0,1) at uvm_fault+0xfb > > > kpageflttrap(ffff800044cc3bb0, ab6ed8ea088) at kpageflttrap+0x171 > > > kerntrap(ffff800044cc3bb0) at kerntrap+0x95 > > > alltraps_kern_meltdown() at alltraps_kern_meltdown+0x7b > > > _rb_min(ffffffff823f89a8,ffff800000278060) at _rb_min+0x23 > > > ieee80211_clean_inactive_nodes(ffff800000277048,a) at > > > ieee80211_clean_inactive_nodes+0x4c > > > > Looks like a corruption in RB-tree used inside > > ieee80211_clean_inactive_nodes(). > > > > Since this is coming from interrupt handler it suggest a missing spl > > dance. > > iwm_intr already runs at IPL_NET. What else would be required?
Are we sure all accesses to `ic_tree' are run under KERNEL_LOCK()+splnet()?
