On Wed, Aug 16, 2023 at 10:37:56AM +0200, Paul de Weerd wrote:
> Hi Jonathan,
> 
> On Wed, Aug 16, 2023 at 04:37:45PM +1000, Jonathan Gray wrote:
> | I'm not sure when AMD added the MSR.
> | family 0fh is Athlon 64, which has microcode updates.
> | 
> | Index: sys/arch/i386/i386/machdep.c
> | ===================================================================
> | RCS file: /cvs/src/sys/arch/i386/i386/machdep.c,v
> | retrieving revision 1.666
> | diff -u -p -r1.666 machdep.c
> | --- sys/arch/i386/i386/machdep.c    9 Aug 2023 00:01:44 -0000       1.666
> | +++ sys/arch/i386/i386/machdep.c    16 Aug 2023 06:26:24 -0000
> | @@ -1863,7 +1863,8 @@ identifycpu(struct cpu_info *ci)
> |             uint64_t level = 0;
> |             uint32_t dummy;
> |  
> | -           if (strcmp(cpu_vendor, "AuthenticAMD") == 0) {
> | +           if (strcmp(cpu_vendor, "AuthenticAMD") == 0 &&
> | +               ci->ci_family >= 0x0f) {
> |                     level = rdmsr(MSR_PATCH_LEVEL);
> |             } else if (strcmp(cpu_vendor, "GenuineIntel") == 0) {
> |                     wrmsr(MSR_BIOS_SIGN, 0);
> 
> Thanks - I can confirm this fixes things on the ALIX.

thanks for the report, committed

Reply via email to