On Tue, Nov 21, 2023 at 08:19:11PM +1100, Jonathan Gray wrote: > On Mon, Nov 20, 2023 at 09:19:45PM +0000, Edd Barrett wrote: > > Hi Jonathan, > > > > On Mon, Nov 20, 2023 at 07:16:14PM +1100, Jonathan Gray wrote: > > > When it last worked, were you running Mesa 23.1 (snapshots since early > > > November)? Did this start with LLVM 16 (last few days)? > > > > Looking back in my messages.0.gz, it seems I hadn't updated in a while. > > > > The last working snapshot I had installed was: > > OpenBSD 7.4-current (GENERIC.MP) #1403: Thu Oct 12 19:56:46 MDT 2023 > > > > Unfortunatley I don't know what Mesa I had at the time. > > That would have been Mesa 22.3.7 > > With Mesa 22.3.7 on -current I can't reproduce the crash.
works with 23.1.9 after reverting https://gitlab.freedesktop.org/mesa/mesa/-/commit/244cc152d1b20592120ce1d5dd9627509b73d0b9 Index: lib/mesa/src/gallium/drivers/r600/sfn/sfn_optimizer.cpp =================================================================== RCS file: /cvs/xenocara/lib/mesa/src/gallium/drivers/r600/sfn/sfn_optimizer.cpp,v retrieving revision 1.1.1.2 diff -u -p -r1.1.1.2 sfn_optimizer.cpp --- lib/mesa/src/gallium/drivers/r600/sfn/sfn_optimizer.cpp 2 Nov 2023 04:32:35 -0000 1.1.1.2 +++ lib/mesa/src/gallium/drivers/r600/sfn/sfn_optimizer.cpp 21 Nov 2023 12:41:07 -0000 @@ -407,11 +407,7 @@ CopyPropFwdVisitor::visit(AluInstr *inst if (can_propagate) { sfn_log << SfnLog::opt << " Try replace in " << i->block_id() << ":" << i->index() << *i << "\n"; - - if (i->as_alu() && i->as_alu()->parent_group()) { - progress |= i->as_alu()->parent_group()->replace_source(dest, src); - } else - progress |= i->replace_source(dest, src); + progress |= i->replace_source(dest, src); } } if (instr->dest()) {
