On 2024/03/25 05:12, Gibson Pilconis wrote: > Hi. > > I'm working on a project that supports OpenBSD and I noticed that > pcidevs_data.h uses > structures defined in pcireg.h but doesn't include the file. As a result, > pcireg.h has to be > included before pcidevs_data.h or else the compiler will throw an error. > > I'm not sure if this is considered a bug or not, but I couldn't find any > documentation of it > and I could easily see it confusing newer developers. If adding an include to > the header isn't > an option, perhaps adding in a comment informing developers they need to > import pcireg.h would > prove useful.
pcidevs_data.h is almost never included directly, the only file in the OpenBSD kernel tree using it is pci_subr.c. So it seems this is probably not really needed?
