Todd C. Miller <mill...@openbsd.org> wrote: > On Wed, 19 Jun 2024 15:17:05 +0200, Otto Moerbeek wrote: > > > Additionally, the implementation in src/libn/libc/string/strmode.c > > needs to start using mode_t. > > > > Building base now with the diff below. So far so good. > > > > But this is more tricky you would think. Modifying string.h to include > > more could have unwanted side effects for applications. > > This looks fine to me but I agree with kettenis@ that just using > __mode_t directly in the prototype would be a bit safer since it > avoids any namespace pollution. I don't expect any problems including > sys/_types.h in place of machine/_types.h.
Agree. I don't think it needs any API/ABI cranks, either.
