On Mon, Jan 13, 2025 at 11:27:41PM -0800, Courtney wrote:
> drm:pid0:parse_general_definitions *ERROR* [drm] *ERROR* Unexpected child
> device config size 40 (expected 39 for VBT version 256)
this should only be cosmetic, but should go away with
'drm/i915/bios: bump expected child device size' from Jani Nikula in
linux 5216ec0eeaee781ae74b79e91a270ea1873cabf5
the GuC warnings look close to what I sometimes see on a Meteor Lake
ThinkPad. Which otherwise works fine.
Index: sys/dev/pci/drm/i915/display/intel_bios.c
===================================================================
RCS file: /cvs/src/sys/dev/pci/drm/i915/display/intel_bios.c,v
diff -u -p -r1.13 intel_bios.c
--- sys/dev/pci/drm/i915/display/intel_bios.c 20 May 2024 05:22:41 -0000
1.13
+++ sys/dev/pci/drm/i915/display/intel_bios.c 14 Jan 2025 12:02:14 -0000
@@ -2726,11 +2726,13 @@ parse_general_definitions(struct drm_i91
expected_size = 37;
} else if (i915->display.vbt.version <= 215) {
expected_size = 38;
- } else if (i915->display.vbt.version <= 250) {
+ } else if (i915->display.vbt.version <= 255) {
expected_size = 39;
+ } else if (i915->display.vbt.version <= 256) {
+ expected_size = 40;
} else {
expected_size = sizeof(*child);
- BUILD_BUG_ON(sizeof(*child) < 39);
+ BUILD_BUG_ON(sizeof(*child) < 40);
drm_dbg(&i915->drm,
"Expected child device config size for VBT version %u
not known; assuming %u\n",
i915->display.vbt.version, expected_size);
Index: sys/dev/pci/drm/i915/display/intel_vbt_defs.h
===================================================================
RCS file: /cvs/src/sys/dev/pci/drm/i915/display/intel_vbt_defs.h,v
diff -u -p -r1.6 intel_vbt_defs.h
--- sys/dev/pci/drm/i915/display/intel_vbt_defs.h 20 May 2024 05:22:41
-0000 1.6
+++ sys/dev/pci/drm/i915/display/intel_vbt_defs.h 14 Jan 2025 12:02:14
-0000
@@ -485,6 +485,7 @@ struct child_device_config {
u8 hdmi_iboost_level:4; /* 196+ */
u8 dp_max_link_rate:3; /* 216+ */
u8 dp_max_link_rate_reserved:5; /* 216+ */
+ u8 efp_index; /* 256+ */
} __packed;
struct bdb_general_definitions {
