Kinsey Moore commented on a discussion on bsps/arm/raspberrypi/include/bsp/raspberrypi-pl011.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/47#note_108736 > +#include <dev/serial/arm-pl011-regs.h> > +#include <dev/serial/arm-pl011.h> > +#include <rtems/termiostypes.h> > + > +typedef struct { > + pl011_base PL011; > + uint32_t reserved_4c[14]; > + uint32_t uartitcr; > + uint32_t uartitip; > + uint32_t uartitop; > + uint32_t uarttdr; > +} raspberrypi_uart; > + > +typedef struct { > + arm_pl011_context pl011_ctx; > +} raspberrypi_pl011_context; Does this mean the current patch is incomplete? The issue I'm bringing up is that the `raspberrypi_pl011_context` structure only exists to provide an accessor for the `arm_pl011_context`. That part of this patch is essentially a no-op as the outer context is never used or passed to any other function. BSPs that use the base implementation don't need the wrapper struct at all and can just use the base struct directly. -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/47#note_108736 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list bugs@rtems.org http://lists.rtems.org/mailman/listinfo/bugs
