Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/80 was reviewed by Kinsey Moore
-- Kinsey Moore started a new discussion on testsuites/fstests/fssymlink/test.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/80#note_109843 > +//#include "fstest_support.h" > +//#include <limits.h> > + These added lines should be removed. -- Kinsey Moore started a new discussion on testsuites/fstests/fsrename/test.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/80#note_109844 > + FS_PASS (); > + else > + FS_FAIL (); These control flow statements should use braces. -- Kinsey Moore started a new discussion on testsuites/fstests/fsrenameexisting/test.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/80#note_109845 > +const char rtems_test_name[] = "FSRENAMEEXISTING " FILESYSTEM; > +const RTEMS_TEST_STATE rtems_test_state = TEST_STATE; > +// This should be a blank line. -- Kinsey Moore started a new discussion on testsuites/fstests/fsrenamepermexisting/test.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/80#note_109846 > +const char rtems_test_name[] = "FSRENAMEPERMEXISTING " FILESYSTEM; > +const RTEMS_TEST_STATE rtems_test_state = TEST_STATE; > +// Remove this line. -- Kinsey Moore started a new discussion on testsuites/fstests/fsrenamepermexisting/test.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/80#note_109847 > + FS_PASS (); > + else > + FS_FAIL (); This needs braces. -- Kinsey Moore started a new discussion on testsuites/fstests/fsrenamepermexisting/test.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/80#note_109848 > + FS_PASS (); > + else > + FS_FAIL (); Braces. -- Kinsey Moore started a new discussion on testsuites/fstests/fssymlink/test.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/80#note_109849 > + FS_PASS (); > + else > + FS_FAIL (); Braces, look for this elsewhere. -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/80 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list bugs@rtems.org http://lists.rtems.org/mailman/listinfo/bugs
