Gedare Bloom commented: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/282#note_114630 I can live with the `size_t`, although I don't agree. The `size_t` has a well-defined origin as the return type of `sizeof`. It doesn't make a lot of sense to use it for something that is not related to object sizes in the units of sizeof. If the `cpu_todo` is multipled by the size of the record to get the number of bytes to transfer, then I would be convinced. But it is not, it is just being used to keep track of how many items are left. Positive counters should just be some kind of unsigned integer type. It's a minor point, but this structure is part of the API between the record event recording and the client, so it should be done properly. In this case, the `size_t` becomes an opaque type for a counter which is awkward but I'm not going to block the MR on this account. I suggest some doxygen in the recordclient.h, but also won't hold up the change on that account. We should have release notes for any API Changes even if we think the API is only used by private tooling. The notes I put in this MR can be used directly. I turned that into an open issue for 6.1. -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/282#note_114630 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
