Joel Sherrill started a new discussion on 
cpukit/include/rtems/score/chainimpl.h: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/747#note_140673

 >    head->next = new_first;
 >    new_first->previous = head;
 >  
 > -#if defined(RTEMS_DEBUG)
 > +#if defined( RTEMS_DEBUG )

There are a lot of changes for spaces after an opening parenthesis and before 
the closing one. Similarly this "if defined()" has spaces added. And "return 
(...)".

K&R did not have spaces i those locations. Checking the [Linux kernel coding 
style](https://www.kernel.org/doc/html/v4.10/process/coding-style.html), it 
leaves these spaces out. It cites K&R for some things.

This appears to be the single source of a lot of changes. And looking at the 
history of the coding style in the documentation, This rule that the existing 
code did not follow appears to just magically appeared when Sebastian created 
that file.

-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/747#note_140673
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to