Mohamed Ayman commented on a discussion on bsps/arm/stm32h7/start/bspstart.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1144#note_146024 > /* Get number of milliseconds elapsed since startup */ > uint32_t HAL_GetTick(void) > { > - return rtems_clock_get_ticks_since_boot() * > - rtems_configuration_get_milliseconds_per_tick(); > + return (uint32_t)( > + (uint64_t) rtems_clock_get_ticks_since_boot() * > + rtems_configuration_get_milliseconds_per_tick() > +); If either operand is a signed type the old multiplication could invoke undefined behavior on overflow, letting the compiler misoptimize. Casting to uint64_t forces unsigned arithmetic where overflow is well defined. The final truncation back to uint32_t is intentional preserving the expected wraparound of a tick counter. -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1144#note_146024 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
