Avi Weiss created an issue: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5559



## Summary
`tms570_bsp_pin_set_function` and `tms570_bsp_pin_clear_function` do not write 
the required unlock codes to the kick registers (which enables write access to 
the PINMMR registers).  

Nor do they clear the kick registers upon completion.  

## Steps to reproduce
I tested this on a TMS570 LC4357 and confirmed that 
`tms570_bsp_pin_set_function` silently fails - the desired set does not take 
effect as the IOMM is effectively still locked.  

## Expected behaviour
unlock the kick registers to enable write access before trying to set a pin 
(and then re-lock afterwards by zeroing out the kick registers).  

See `tms570_bsp_pin_config_one` and `tms570_bsp_pinmmr_config` which do 
correctly call `tms570_pin_config_prepare` and `tms570_pin_config_complete` to 
enable/disable write access.

-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5559
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to