Avi Weiss created a merge request: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1218
Project:Branches: thnkslprpt/rtems:fix-5559-tms570-pin-set-clear-unlock to rtems/rtos/rtems:main Author: Avi Weiss ## Summary Fixes #5559 Added the `tms570_pin_config_prepare` and `tms570_pin_config_complete` helper calls to `tms570_bsp_pin_set_function` and `tms570_bsp_pin_clear_function` which are required to unlock the IOMM and enable write access. Added comment next to IOMM kick register unlock codes to make the source and purpose of the magic numbers clear. (could also consider just making them #define constants instead). Also disabled interrupts during the operation for this small critical section, as does the similar function `tms570_bsp_pin_config_one`. Separate commits on same file: - use unsigned constants for pin register shifts to protect against left-shifting too far into the signed bit which could cause undefined behavior. - clear up pinmux documentation typos and unclear comments - apply RTEMS clang format to `pinmux.c` Tested on TMS 570 LC43 - `tms570_bsp_pin_set_function` and `tms570_bsp_pin_clear_function` now work as expected and are able to make changes to the lock-protected PINMMR registers. ## Generative AI None -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1218 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
