Gedare Bloom commented on a discussion on 
testsuites/validation/tc-intr-set-priority.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1254#note_151706

 >    }
 >  
 >    sc = rtems_interrupt_set_priority( vector, priority );
 > +
 > +    /*
 > +    * Some BSPs support full uint32_t priority range
 > +    * UINT32_MAX may be valid. 
 > +    */ 
 > +    if ( !ctx->valid_priority && sc == RTEMS_SUCCESSFUL ){

I think this is still just short-circuiting the test for all targets.

I suppose the right solution here is to define a configuration value for the 
largest value of IRQ priority that a BSP supports. What's not clear to me is if 
this value will be BSP-specific or if it is CPU-specific. I think there are 
some BSPs that have less/more IRQ priorities available than others in the same 
CPU, so we probably need it to be a BSP option. Then we can filter the test 
using that configuration value.

I would add something like a new configuration option 
`BSP_IRQ_PRIORITY_VALUE_MAX` as this generalizes several existing configuration 
options that are similar. We could also define a CPU default for this, and 
override it by the BSPs.

-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1254#note_151706
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to