Gedare Bloom started a new discussion on bsps/powerpc/beatnik/start/bspstart.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1276#note_152547 > printk("Number of PCI buses found is : %d\n", pci_bus_count()); > #endif > > + motload_gev_set_nvbase(BSP_NVRAM_BASE_ADDR); > + if (board_type == MVME5500) { > + motload_gev_set_net_unit(1); > + motload_gev_set_net_label(1, "em0"); > + } else { > + motload_gev_set_net_unit(1); > + motload_gev_set_net_unit(2); > + motload_gev_set_net_label(1, "em0"); nit: it would seem sensible to me to keep together the calls that have the same index, i.e., ``` set_net_unit(1); set_net_label(1, "em0"); set_net_unit(2); set_net_label(2, "em1"); ``` -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1276#note_152547 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
