Hi, On Thu, 2008-11-13 at 13:27 +0100, Mark Wielaard wrote: > On Sat, 2008-11-08 at 21:42 +0100, Mark Wielaard wrote: > > The langtools now use a new ant based build Makefile. This new build > > does not obey the setting of MILESTONE to the magic string "fcs" like > > the rest of the build to get version strings without an -internal build > > string marker. > > > > We use this feature in IcedTea to make sure the version strings of all > > the tools are correct in releases (we additionally have some tweaks so > > the version string can embed the hg tip node number and/or a distro > > specific indicator). > > > > Attached is a patch that fixes up the ant build Makefile to do the same > > as the original Makefile-classic with respect to the release string when > > MILESTONE is set to "fcs". > > So, is this patch useful? And if so anything I can do to help make it go > in sooner? Or should we just keep this divergence in IcedTea?
If this is not the right way to do things just let me know. And we can come up with something different/better. How do people produce production builds currently? The thing that triggered this patch was that the tools currently always include some <release>-<milestone> thing, where milestone defaults to "internal" and the dash (-) is hardcoded (so even setting milestone to "" wouldn't help). But maybe I am missing something in setting up the correct build environment variables. Cheers, Mark
