2009/5/29 Mark Reinhold <m...@sun.com>: >> Date: Thu, 21 May 2009 16:51:24 +0100 >> From: Andrew John Hughes <gnu_and...@member.fsf.org> > >> ... >> >> Looks like the Contributed-by info is wrong. I tried adding the line >> as in the example and jcheck choked: >> >> remote: > Contributed-by: Andrew John Hughes <ahughes at redhat.com> >> remote: >> remote: Invalid contributor attribution >> remote: >> remote: abort: pretxnchangegroup.0.jcheck hook failed >> >> The example is Contributed-by: Ben Bitdiddle <ben at bits.org> > > Right -- as Jon already pointed out, this is a bug in the example. > > More the the point, however, you didn't need a Contributed-by line in > your comment since you are the author. That line is meant to be used > only when the author of the changeset (in hg terms) is not the sole > author of the actual patch. > > - Mark >
That's good to hear. Thanks for the clarification as it doesn't seem obvious from the guide. BTW, I also noticed that the -m Merge trick is missing or at least I can't see it on http://openjdk.java.net/guide/repositories.html or http://openjdk.java.net/guide/producingChangeset.html And now I can't find the mail either :( Thanks again, -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
