Hi Kelly: > We have run into a corba build problem, not all the classes are > getting delivered via the corba/dist/lib/classes.jar file. > > It appears to be some strange interaction with VPATH and the > wildcard logic I added recently in changeset > http://hg.openjdk.java.net/jdk7/build/corba/rev/1c130e7b7a2e > > I filed > 6883790: corba build problem related to wildcard and vpath, regression > > Webrev is here: > http://cr.openjdk.java.net/~ohair/openjdk7/corba-build-problem/webrev/ > > I'm just putting back the FIND logic instead of using wildcard.
Approved. I see you are restoring the old find logic removed in changeset 1c130e7b7a2e: http://hg.openjdk.java.net/jdk7/build/corba/diff/1c130e7b7a2e/make/common/Rules.gmk So these changes are not quite as scary as they look at first glance, since we have already been using them. > Not everyone was seeing the problem, so it's some kind of strange > unpredictable thing that isn't seen by everyone. > I only managed to reproduce it on a solaris 10 sparc machine. These have not hit the TL forest yet, so I don't have anything to report about predictability. Tim
