2009/10/23 Kelly O'Hair <kelly.oh...@sun.com>: > > Sigh... if I'm changing jaxp, might as well change jaxws too.... > keep them in sync. > > I effectively included the drop.dir change you wanted with these > webrevs: > > http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-jaxp/webrev/ > http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-jaxws/webrev/ > > In both cases, any use of the original source is being removed, and > the changeset I create will probably just delete the "src/" directory. >
Good, makes things clearer. > I'm using a different directory name when the dropped sources are > baked in by our RE people, "drop_included" (should have called these > batteries so I could use "batteries_included". ;^) > Ok, I think it makes the build.xml more complicated than necessary, given you could just set drop.dir for builds which include the source, but I'm happy enough with it. > So there are two properties drop.expanded.dir and drop.included.dir, > and the drop.dir property is conditional set in the ant script. > > But I did not add the ALT_DROPS_DIR change. > Do you want me to include that, or do you want to make that change > separately? > There's already three changes in this one changeset: * Removing the original source option * Adding drop.expanded (which seems similar to the original source option except you can specify the directory) * Checksumming so I'd rather we had the ALT_DROPS_DIR in a separate one, but I don't mind who commits it. I also notice the URL changes -- why? > -kto > Thanks, -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
