Andrew John Hughes wrote:
2009/11/19 Kelly O'Hair <kelly.oh...@sun.com>:
Need reviewer. Some very minor top level make file changes.
6727046: Add message when docs are skipped in control build
6864011: typo? in top level Makefile: DAYE_STAMP
http://cr.openjdk.java.net/~ohair/openjdk7/top-make-fixes/webrev/
-kto
This is a bit more than just adding a message. It also adds:
+ # No DOCS build when JDK_UPDATE_VERSION set
+ ifdef JDK_UPDATE_VERSION
+ GENERATE_DOCS=false
+ endif
Sorry about that, I assumed I was making a correction to a long standing
problem. When we build jdk update releases, the docs are not regenerated.
The variable JDK_UPDATE_VERSION indicates a jdk update build, I
just assumed that's what it was being used for.
JDK_UPDATE_VERSION has to be set for IcedTea to deal with broken
plugins which expect this (such as
http://www.java.com/en/download/help/testvm.xml). I don't think it
follows that turning on a version setting forces documentation off.
Can we make this an #ifndef OPENJDK block?
Strange use of JDK_UPDATE_VERSION if you ask me.
Why not just 'make GENERATE_DOCS=true' with the IcedTea builds?
Or am I missing the point?
What exactly is it that JDK_UPDATE_VERSION provides for IcedTea builds?
-kto