David Holmes-9 wrote: > >> Shouldn't jdk_generic_profile.sh use braces instead of round brackets? >> That >> is, ${PROCESSOR_IDENTIFIER} instead of $(PROCESSOR_IDENTIFIER)? Is this a >> bug in the makefile? > > It's a bug in the script - a typo introduced by this recent changeset: > > changeset: 970:90873391a0e0 > parent: 945:fea0898259ae > user: ohair > date: Thu Mar 26 16:52:00 2009 -0700 > summary: 6822374: Windows: detect X64 when PROCESSOR_IDENTIFIER > contains EM64T or Intel64 > > diff -r fea0898259ae -r 90873391a0e0 make/jdk_generic_profile.sh > --- a/make/jdk_generic_profile.sh Tue Mar 17 13:45:01 2009 -0700 > +++ b/make/jdk_generic_profile.sh Thu Mar 26 16:52:00 2009 -0700 > @@ -174,7 +174,8 @@ else > > # Check CYGWIN (should have already been done) > # Assumption here is that you are in a shell window via cygwin. > - if [ "$(echo ${PROCESSOR_IDENTIFIER} | fgrep AMD64)" != "" ] ; then > + proc_arch=`echo "$(PROCESSOR_IDENTIFIER)" | expand | cut -d' ' -f1 | > sed -e 's...@x86@x...@g' -e 's...@intel64@x...@g' -e 's...@em64t@x...@g' -e > 's...@em64t@x...@g' -e 's...@amd64@x...@g' -e 's...@amd64@x...@g' -e > 's...@ia64@i...@g'` > + if [ "${proc_arch}" = "X64" ] ; then > windows_arch=amd64 > else > windows_arch=i586 > > David Holmes >
Silly question: how did no one catch this for 14 months?! Notice the date reads 2009 not 2010. Secondly, does anyone plan on committing a fix? :) Who do I report to in general if I run across other bugs in the build process? Thanks, Gili -- View this message in context: http://old.nabble.com/PROCESSOR_IDENTIFIER%3A-command-not-found-tp28793595p28809115.html Sent from the OpenJDK Build Infrastructure mailing list archive at Nabble.com.