Hi David, On Tue, 2010-11-16 at 11:32 +1000, David Holmes wrote: > It is very odd that noone has encountered this. > > You can fix it by editing the file and replacing the 8 spaces with a TAB. > > David Holmes
Thanks for the tip. After a couple re-reading the lines if think that the whole "else" block is not needed. After changing a couple more lines I got the sanity check working successfully under Fedora 14 (see patch): Now I get the following error when trying to build: > BUILD FAILED > /home/pr/hgrepos/jdk7/jaxp/build-defs.xml:70: ERROR: Cannot find source > for project jaxp. > > HINT: Try setting drops.dir to indicate where the bundles can be found, > or try setting the ant property allow.downloads=true to download the > bundle from the URL. > e.g. ant -Dallow.downloads=true -OR- ant -Ddrops.dir=some_directory > > Total time: 0 seconds > make[2]: *** [all] Error 1 > make[2]: Leaving directory `/home/pr/hgrepos/jdk7/jaxp/make' > make[1]: *** [jaxp-build] Error 2 > make[1]: Leaving directory `/home/pr/hgrepos/jdk7' > make: *** [build_product_image] Error 2 How do I specify those suggested ANT parameters with the make command? Regards Patrick
diff -r ecab7eefb8f2 make/common/shared/Sanity.gmk --- a/make/common/shared/Sanity.gmk Thu Nov 11 11:02:24 2010 -0800 +++ b/make/common/shared/Sanity.gmk Tue Nov 16 23:51:25 2010 +0100 @@ -1389,20 +1389,13 @@ endif sane-alsa-headers: ifdef REQUIRED_ALSA_VERSION - if [ "$(ALSA_CHECK)" != "same" -a "$(ALSA_CHECK)" != "newer" ] ; then \ + @if [ "$(ALSA_CHECK)" != "same" -a "$(ALSA_CHECK)" != "newer" ] ; then \ $(ECHO) "ERROR: The ALSA version must be $(REQUIRED_ALSA_VERSION) or higher. \n" \ - " You have the following ALSA version installed: $${alsa_version) \n" \ + " You have the following ALSA version installed: $(ALSA_VERSION) \n" \ " Please reinstall ALSA (drivers and lib). You can download \n" \ " the source distribution from http://www.alsa-project.org \n" \ " or go to http://www.freshrpms.net/docs/alsa/ for precompiled RPM packages. \n" \ "" >> $(ERROR_FILE) ; \ - fi \ - else \ - $(ECHO) "ERROR: You seem to not have installed ALSA $(REQUIRED_ALSA_VERSION) or higher. \n" \ - " Please install ALSA (drivers and lib). You can download the \n" \ - " source distribution from http://www.alsa-project.org or go to \n" \ - " http://www.freshrpms.net/docs/alsa/ for precompiled RPM packages. \n" \ - "" >> $(ERROR_FILE) ; \ fi endif