On Feb 3, 2011, at 10:41 AM, [email protected] wrote:
Kelly,
webrev looks good.
RE script takes product or fastdebug as a parameter and pass it to
make:
if [ $build_variant_arg = "fastdebug" ]; then
gnumake all SKIP_PRODUCT_BUILD=true $newarg $OP $JUNIT
If this line above is supposed to build fastdebug, you need to change
it to:
gnumake all SKIP_PRODUCT_BUILD=true SKIP_FASTDEBUG_BUILD=false
$newarg $OP $JUNIT
elif [ $build_variant_arg = "product" ]; then
gnumake all SKIP_FASTDEBUG_BUILD=true $newarg $OP $JUNIT
The above is fine.
else
gnumake all $newarg $OP $JUNIT
If this line above is supposed to build both, you need to change it to:
gnumake all SKIP_FASTDEBUG_BUILD=false $newarg $OP $JUNIT
fi
Instead of settting SKIP_FASTDEBUG_BUILD=false,
does setting SKIP_PRODUCT_BUILD=true (first if condition) cause none
of product and fastdebug get built?
Yes.
You can make these changes anytime too, won't hurt the current
situation.
-kto
Thanks
Christine
David Katleman (Oracle) wrote:
Looks fine Kelly.
Dave
Kelly O'Hair wrote:
Need reviewer: No fastdebug builds by default
One word change. Default builds from the root will be faster due
to not building the fastdebug images.
This change is in the open repository but will only impact our
closed jdk builds.
Currently when building the openjdk from the top of the forest, it
only builds one image, the so
called "product" image. This change does the same for closed jdk7
builds.
FYI.. The fastdebug builds are built with slightly lower native
compiler optimization levels,
all assert checking enabled, and include more debug information.
The java classes may also
include local variable debugging information. These are mostly for
developers but can be used
to isolate runtime issues in a jdk.
Anyone wanting both builds or the old behavior would need to use:
make SKIP_FASTDEBUG_BUILD=false
7014634: By default, only build the product bits with a closed jdk
build (like openjdk does)
http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-nofastdebug/webrev/
-kto
