On 08:26 Tue 22 Feb , Kelly O'Hair wrote: > > On Feb 22, 2011, at 5:42 AM, Dr Andrew John Hughes wrote: > > > On 12:54 Tue 22 Feb , Alan Bateman wrote: > >> Dr Andrew John Hughes wrote: > >>> It seems that the OpenJDK build installs a man page for javaws, > >>> yet there is no javaws implementation in OpenJDK. > >>> > >>> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=633 > >>> > >>> This only happens on 32-bit platforms, hence why I've never seen it > >>> myself. I've posted a webrev: > >>> > >>> http://cr.openjdk.java.net/~andrew/javaws/webrev.01/ > >>> > >>> which disables the installation when building OpenJDK. If you don't > >>> need this man page for the proprietary installation either, we could > >>> instead just get rid of the man pages and the appropriate lines in > >>> the > >>> Makefile. > >>> > >>> Thoughts? > >>> > >> Probably a small oversight that just wasn't noticed before. > > > > It's taken me this long to notice it. If you build on a 64-bit > > platform, > > you're not going to see it. It seems distros have been silently > > deleting > > it for a while without bothering to tell upstream :-( > > > >> I've > >> created a bug to track it: > >> > >> 7021314: Build should not install javaws man page > >> > > > > Great. Thanks. I'll await Kelly's review. > > Looks ok to me. > > -kto > > > > >> The changes in the webrev look right solution to me but I'll leave > >> it to > >> Kelly to review. > >> > >> -Alan. > > > > -- > > Andrew :) > > > > Free Java Software Engineer > > Red Hat, Inc. (http://www.redhat.com) > > > > Support Free Java! > > Contribute to GNU Classpath and IcedTea > > http://www.gnu.org/software/classpath > > http://icedtea.classpath.org > > PGP Key: F5862A37 (https://keys.indymedia.org/) > > Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37 >
Thanks Alan & Kelly. Pushed: http://hg.openjdk.java.net/jdk7/build/jdk/rev/5e09deee1967 -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: F5862A37 (https://keys.indymedia.org/) Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37
