Re: Need reviewer: Turn off warnings for mapfiles in fastdebug builds

[Daniel D. Daugherty]

Looks good to me also. :-) Dan P.S. So the missing "endif" at the end didn't cause any errors? On 4/5/2011 6:29 PM, Kelly O'Hair wrote: Sorry... I put dcubed down as the reviewer and meant to put dholmes. :^( It's been a long day... :^( Need to go home and get some sleep. Thank you for the review, you too Dan. ;^) -kto On Apr 5, 2011, at 5:17 PM, David Holmes wrote: Looks good to me. David Kelly O'Hair said the following on 04/06/11 09:53: Strange... I need a reviewer on this small change.... not sure why my email never showed up. :^( Begin forwarded message: *From: *Kelly O'Hair <kelly.oh...@oracle.com <mailto:kelly.oh...@oracle.com>> *Date: *April 5, 2011 11:56:25 AM PDT *To: *build-dev <build-dev@openjdk.java.net <mailto:build-dev@openjdk.java.net>> *Subject: **Need reviewer: Turn off warnings for mapfiles in fastdebug builds* Need reviewer: Turn off warnings for mapfiles in fastdebug builds The mapfiles are generally not used on fastdebug or debug builds, this just turns off the warning in these cases, making it just an informative piece of information. 7033960: Do not check for mapfiles when fastdebug building http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-mapfile-warning/webrev/ -kto