Hi Kelly,
I think this looks fine.
There is nothing special about the name SUNWprivate_1.1, if you want a
different name we can accommodate that.
True, but we check for SUNWprivate though for instance, so I guess for
now we should
keep everything consistent.
ex:
% grep SUNWprivate *
Defs-linux.gmk: if [ "`$(NM) -D -g --defined-only $1 | $(EGREP)
'SUNWprivate'`" = "" ] ; then \
Defs-solaris.gmk: if [ "`$(NM) -g -D $1 | $(EGREP) -v 'UNDEF' |
$(EGREP) 'SUNWprivate'`" = "" ] ; then \
With JDK8 I'd like to change them all to JDK1.8.0 for the explicitly public
externs, and maybe
JDK_private_1.8.0 for all the extern symbols only used internal to the jdk, but
that's for another day.
+1, but I would suggest JAVA_private_* vs. JDK_private_*.
Thanks for the review.
Kumar
-kto
On Apr 6, 2011, at 2:25 PM, Kumar Srinivasan wrote:
Hi,
This is for adding mapfiles to all launcher based tools as well as unpack200,
which eliminates the warning messages for the tools during build.
http://cr.openjdk.java.net/~ksrini/7033954/webrev.0/
Thanks
Kumar
