David Holmes said the following on 05/04/11 12:31:
No. Unless you use -e a variable's value from the environment will be
overridden by an explicit assignment in the Makefile. Which means that
the better fix here is:
+ 36 ifndef HS_ALT_SRC_REL
37 ifneq ($(OPENJDK),true)
38 # This needs to be changed to a more generic location, but we
keep it as this
39 # for now for compatibility
40
41 HS_ALT_SRC_REL=src/closed
42 else
43 HS_ALT_SRC_REL=$(HS_COMMON_SRC_REL)
44 endif
+ 45 endif
For some reason I can not fathom the above does not work. I set
HS_ALT_SRC_REL=src/closed and OPENJDK=true but it acts as if
HS_ALT_SRC_REL is not set - though I do see some weird empty lines being
generated into the .make files created by buildtree.make
This seems to run contrary to reports that people could have src/closed
be ignored simply by setting HS_ALT_SRC_REL to some non-existent
directory! That doesn't appear to be happening for me.
Further, on closer inspection setting
HS_ALT_SRC_REL=$(HS_COMMON_SRC_REL)
is a bad idea because we actually end up with duplicate path entries in
the .make files created by buildtree.make. I don't know if these cause
twice as much work or are ignored, but it's not clean regardless.
I've reached the point where this notionally simple fix has now consumed
far too much time and doesn't have a satisfactory resolution. I will
defer the CR to HS22 and let someone else pick it up if they want.
David
-----
