Hi Kelly, Kelly O'Hair <kelly.ohair@...> writes: > > > Need reviewer: Added test target and makefile cleanups > > 6960335: Add top level 'make test' rule that uses test/Makefile, runs > all test batches > 6960853: Cleanup makefiles, remove unused vars etc. > > http://cr.openjdk.java.net/~ohair/openjdk7/test-target-cleanup/webrev/ >
I know it's a little late, but I wanted to point out that this patch (sort of) breaks using ALT_OUTPUTDIR and doing debug builds. If I set ALT_OUTPUTDIR=/some/dir, the debug build is placed in /some/$(PLATFORM)-$(ARCH)-$(DEBUGNAME) instead of /some/dir-$(DEBUGNAME). Is this intentional and using ALT_OUTPUTDIR like this not supported? In IcedTea6, we carry a patch [1] that effectively reverts this changeset just so that we can avoid this strange behaviour. Thanks, Omair [1] http://icedtea.classpath.org/hg/icedtea6/file/b434625f3fd8/patches/debug-dir.patch
