This change looks fine to me. It would be ok with me for this change to be pushed into the jdk8/build forest. Once there, I can do a JPRT run to verify it, but I really don't seen any issue here.
-kto On Jan 30, 2012, at 4:57 PM, David Holmes wrote: > Hi Deepak, > > The primary change here is a build change so I've cc'ed build-dev. > > The majority of the changes are to JVMTI demo files hence I've cc'd > serviceability-dev. > > I think JDK8-dev doesn't need to be included now so I've bcc'd it. > > While gcc compilation on sparc is rare I'm not sure that simply deleting the > sparc-only option unconditionally is the right thing to do. > > David > > On 31/01/2012 1:20 AM, Deepak Bhole wrote: >> Hi, >> >> JDK builds currently fail with GCC 4.7 due to its stricter option >> checking. >> >> GCC 4.6 and prior ignored invalid options -- GCC 4.7 does not. Certain >> files in JDK supply the -mimpure-text option to GCC. This option is only >> valid on SPARC[1,2]. As a result, GCC 4.7 throws an error during build >> on Linux (I suppose . >> >> This patch removes the option: >> http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.00 >> >> 1: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/SPARC-Options.html >> 2: >> http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/i386-and-x86_002d64-Options.html >> >> If OK for push, please feel free to do so (I don't have commit access). >> >> Cheers, >> Deepak
