On 1/02/2012 5:53 AM, Staffan Larsen wrote:
Looks good, but where is the new jre_release_version() method used?
It's currently only used in some closed code. The new method avoids the
need to make the JRE_RELEASE_VERSION define available to that closed code.
I don't understand the comment on the new method though. Not sure what
stringstream has to do with this actual method.
Otherwise looks good to me. I'm assuming that the actual problem is the
ccache compares the defines used for a compilation and so if the version
string contains a timestamp and gets updated on each (incremental?)
build then ccache thinks it has to recompile.
David
-----
/Staffan
On 31 jan 2012, at 13:31, Fredrik Öhrström wrote:
Hello hotspot-runtime-dev and build-dev!
This is a patch to enable ccache to work for all builds,
not only builds where the build number has been explicitly set.
Webrev is here:
http://cr.openjdk.java.net/~ohrstrom/7132779/webrev.00/
Exported hg patch is here:
http://cr.openjdk.java.net/~ohrstrom/7132779/webrev.00/7132779.patch
Is it good enough, so that you can commit for me Robert?
Thanks!
//Fredrik
