* David Holmes <david.hol...@oracle.com> [2012-02-29 18:48]: > Sorry let me back up a step here. The issue with linux-sparc > involved the actual build instructions in Compiler-gcc.gmk, not so > much the sample makefiles for the various JVMTI demos - at least in > my response. Unless someone from serviceability indicates otherwise > I'd suggest just deleting -mimpure-text from those samples. > > Just to confuse things further, the gcc manual now lists this as a > Solaris 2 option _not_ a sparc option: > > http://gcc.gnu.org/onlinedocs/gcc/Solaris-2-Options.html#index-mimpure_002dtext-2103 > > http://old.nabble.com/Correctly-document-Solaris-2-options-td29851048.html > > This seems to indicate the gcc folk are ignorant of linux-sparc! >
Gah :/ > As we only used this option for linux builds and not Solaris builds > I find this even more confusing. > > So at this point I will step back and let the build folk figure it out. > Removing it might probably be correct then, since it is not applicable to Linux. I will wait for someone with more experience to chime in though. Cheers, Deepak > David > ----- > > On 1/03/2012 9:28 AM, David Holmes wrote: > >Hi Deepak, > > > >On 1/03/2012 6:30 AM, Deepak Bhole wrote: > >>* David Holmes<david.hol...@oracle.com> [2012-01-30 21:50]: > >>>On 31/01/2012 12:36 PM, Deepak Bhole wrote: > >>>>* David Holmes<david.hol...@oracle.com> [2012-01-30 19:57]: > >>>>>While gcc compilation on sparc is rare I'm not sure that simply > >>>>>deleting the sparc-only option unconditionally is the right thing to > >>>>>do. > >>>>> > >>>> > >>>>I thought about that too. But I was unable to find info on OpenJDK + > >>>>SPARC + Linux. Is that combination even supported? The README doesn't > >>>>list it: > >>>>http://hg.openjdk.java.net/jdk6/jdk6/raw-file/tip/README-builds.html#MBE > >>>> > >>> > >>>Linux-sparc is not one of Oracle's supported OpenJDK platforms. > >>>However AFAIK there are people in the community building OpenJDK on > >>>Linux-sparc using the Zero interpreter. I don't know if this would > >>>affect them but it still seems to me that we should be careful not > >>>to break other people's builds. > >>> > >> > >>With FOSDEM and subsequent security errata, this got pushed to side. > >> > >>Sorry for the delay. I've created a new webrev which contains a special > >>case for the Sparc family (on Linux): > >> > >>http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.01/ > > > >Where is ARCH_FAMILY being set? > > > >David > > > > > >>If it is okay for push, please go ahead and push it (I don't have commit > >>access). I will then propose it for 7u. > >> > >>Thanks, > >>Deepak > >> > >>>David > >>>----- > >>> > >>>>The option seemed more like a relic from Solaris + SPARC config rather > >>>>than a requirement for Linux + SPARC. > >>> > >>> > >>> > >>>>Cheers, > >>>>Deepak > >>>> > >>>>>David > >>>>> > >>>>>On 31/01/2012 1:20 AM, Deepak Bhole wrote: > >>>>>>Hi, > >>>>>> > >>>>>>JDK builds currently fail with GCC 4.7 due to its stricter option > >>>>>>checking. > >>>>>> > >>>>>>GCC 4.6 and prior ignored invalid options -- GCC 4.7 does not. > >>>>>>Certain > >>>>>>files in JDK supply the -mimpure-text option to GCC. This option > >>>>>>is only > >>>>>>valid on SPARC[1,2]. As a result, GCC 4.7 throws an error during > >>>>>>build > >>>>>>on Linux (I suppose . > >>>>>> > >>>>>>This patch removes the option: > >>>>>>http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.00 > >>>>>> > >>>>>>1: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/SPARC-Options.html > >>>>>>2: > >>>>>>http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/i386-and-x86_002d64-Options.html > >>>>>> > >>>>>> > >>>>>>If OK for push, please feel free to do so (I don't have commit > >>>>>>access). > >>>>>> > >>>>>>Cheers, > >>>>>>Deepak
