2012-03-26 18:13, Kelly O'Hair skrev:
* The "@GenerateNativeHeader" additions seem like they deserve some kind of comment,
maybe a short one on the same line, like "No native methods here, but the constants are needed
in the supporting JNI code" or something like that?
Good idea!
* The top repo's additions are a bit of a mind blower. Lots of stuff here.
Haven't seem m4 files in a long time. ;^)
- In common/makefiles/IdlCompilation.gmk, lines 82-84 it says
82 $(if $3,$1_$(strip $2))
83 $(if $3,$1_$(strip $3))
84 $(if $4,$1_$(strip $4))
Is line 82 right? $3 and not $2?
Thank you for catching this! It is a bug, but the code works anyway,
since there is always at least 3 arguments.
- In common/makefiles/MakeBase.gmk, this is very strange to me:
134 compress_pre:=$(strip $(shell cat
$(SRC_ROOT)/common/makefiles/compress.pre))
135 compress_post:=$(strip $(shell cat
$(SRC_ROOT)/common/makefiles/compress.post))
This path mapping logic seems like high maintenance. I understand what it
is trying to get around,
and I don't have any suggestions for improvements at this time, but it
does look very very touchy stuff. :^(
The good thing is that we have only one copy of it, and if anyone figures
out a better way, we can change it, in one place.
Well, the compression does not need to be perfect, it just helps out
when chunking a list of paths into units that can be handled by
the command line length limits on cygwin and solaris. If there was a
single feature that I would like to have in make, it would
be a way to export a variable to a file on disk, without having to go
through the command line. This is particularly problematic
with Java since there are so many more Java sources in a Java project,
than there are C sources in a C-project. Not even the
list of packages in the jdk fits on the cygwin command line!
//Fredrik
