Hi David,

The fix looks fine to me. Is the empty line 281 OK in Makefiles? I'd remove it just in case. Besides it would make it more clearer that the SIZERS_CC commands are related to the SIZERS target.

--
best regards,
Anthony

On 5/25/2012 10:20 AM, David Holmes wrote:
This is a tweak to the cross-compilation rules in sun/xawt/Makefile to force correct compilation of the sizers utility.

http://cr.openjdk.java.net/~dholmes/7171653/webrev/

webrev is against tl/jdk but I can use a different repo if you prefer.

Now that we use CFLAGS_32/64 in the cross compilation case we no longer need different cc commands, other than the actual choice of compiler.

Longer term 7153072 will make this fix obsolete but for now we need this for our new build servers, and I wanted to make sure this only affected cross-compilation.

Same change will need to go to the 7u train as well.

Thanks,
David

Reply via email to