Hi Omair,
The fix looks good to me. I think Kumar needs to take a look at it, too,
before the fix can be pushed to a repo.
Thanks for finding and fixing this issue.
--
best regards,
Anthony
On 8/10/2012 1:48 AM, Omair Majid wrote:
On 08/09/2012 07:15 AM, Andrew Hughes wrote:
----- Original Message -----
Hi Kumar,
On 07/23/2012 11:19 AM, Kumar Srinivasan wrote:
My suggestion is to see if System.loadLibrary can be used, this
will
bode well for the modularization effort.
I discussed this with the folks at awt-dev and they would prefer to
avoid loading as much as possible. They are strongly against always
preloading libjawt.so.
For my 2c, I'm against it too. It doesn't seem the right fix.
I can see your point, but both the solutions feel wrong to me. I can't
make up my mind which is the less bad.
I don't see an attachment :-(
I guess the mailing list software stripped it out. I did attach it.
Shouldn't it be a webrev anyway?
Old habits :)
Webrev is at:
http://cr.openjdk.java.net/~omajid/webrevs/jawt-link-regression/00/
I have also put up a test case at:
http://cr.openjdk.java.net/~omajid/jawt-test.tar.gz
The test case is the exact same as that on
http://download.java.net/jdk8/docs/technotes/guides/awt/AWT_Native_Interface.html,
except it automates the building and running. You will have to edit the
makefile to set the value of JDK_HOME. It should point to a j2sdk-image
directory.
Then do:
$ make
$ make run
Without the fix it should print an UnsatisfiedLinkError. With the fix,
it should show a window.
I built jdk8/build successfully just last week. What issues are you seeing?
Errors building hotspot, I seem to recall. But I cant reproduce it
anymore after pulling today. I can now confirm that the fix works for me
with jdk8 too.
Thanks,
Omair
