On 10/17/2012 11:29 AM, Kelly O'Hair wrote:
Looks ok to me. Did you plan on integrating it into jdk8/build?
I can do that. Thanks for reminding me - my local repo is a clone of jdk8/tl.
Mandy
-kto On Oct 17, 2012, at 11:11 AM, Mandy Chung wrote:I need a reviewer to fix this build problem that only affects partial build. make/common/internal/Defs-jaxws.gmk maintains an explicit list of JAXWS packages to import from a JDK for a partial JDK. However, the list was not up-to-date and missing some JAXWS classes. You can reproduce the problem by doing SKIP_CYCLE_BUILD=false BUILD_JAXWS=false and got this exception: Exception in thread "main" java.lang.NoClassDefFoundError: com/sun/istack/internal/FinalArrayList The fix is to add the missing packages to the list: diff --git a/make/common/internal/Defs-jaxws.gmk b/make/common/internal/Defs-jaxws.gmk --- a/make/common/internal/Defs-jaxws.gmk +++ b/make/common/internal/Defs-jaxws.gmk @@ -34,6 +34,10 @@ javax/xml/ws \ javax/jws \ javax/annotation \ + com/sun/org/glassfish \ + com/sun/istack/internal \ + com/sun/istack/internal/localization \ + com/sun/istack/internal/logging \ com/sun/xml/internal/bind \ com/sun/xml/internal/fastinfoset \ com/sun/xml/internal/messaging \ Thanks Mandy
