On 11/6/12 10:08 PM, David Holmes wrote:
webrev:
http://cr.openjdk.java.net/~dholmes/8002040/webrev/
Thumbs up.
make/common/Defs-linux.gmk
No comments.
This is a simplified variant of the change just made to Hotspot.
Instead of disabling FDS when cross-compiling we change the default
location of objcopy, and just as with native compilation either the
default objcopy is found or we try to fallback to ALT_OBJCOPY if set.
I would phrase it a little differently:
- you changed the default location of objcopy when cross compiling
is enabled which potentially enables FDS for cross compiling
- if ALT_OBJCOPY is set, then that value is used (even if it does
not refer to an executable program)
Setting ALT_OBJCOPY to some non-existent value is the means by which
FDS can be completely disabled for all build configs on both Linux and
Solaris. Note: there isn't a means to disable FDS on all build configs
on Windows.
Dan
In other words the only difference between the two cases is the chosen
default. (Arguably both cases could just use COMPILER_PATH/objcopy but
that might change existing behaviour in some cases - which we do not
want to do).
I will push this via the build repo. There are no corresponding
changes needed to the new build as it handles FDS differently.
This only impacts Linux.
Thanks,
David
